Should the Milestone object implement Closable and Updatable?

schema-request

#1

The Milestone object is missing the closedAt and updatedAt fields (see the REST API). I’m not 100% sure, but I feel that it would make sense for the Milestone object to implement the Closable and Updatable interfaces.

When listing milestones, it’s fairly common to want to sort them by updated date or by closing date (for closed milestones).

Is it possible to include the fields (or to implement the corresponding interfaces)? Cheers!


#2

It should! I’ll add this to the backlog as a quick win.


#3

Hi @pnavarrc! Just wanted to let you know that we’ve added the closedAt, updatedAt, and createdAt fields to the Milestone object. Here’s an example query:

{
  repository(name: "hub", owner: "github") {
    milestones(first:1) {
      nodes {
        title
        createdAt
        updatedAt
        closedAt
      }
    }
  }
}

and the result:

{
  "data": {
    "repository": {
      "milestones": {
        "nodes": [
          {
            "title": "1.11-stable",
            "createdAt": "2013-12-14T12:28:05Z",
            "updatedAt": "2014-07-25T23:48:05Z",
            "closedAt": "2014-07-25T23:48:05Z"
          }
        ]
      }
    }
  }
}

#4

Oh! And I forgot to mention - Milestone was updated to implement the Closable interface, but it turns out that updatedAt is not actually a field on the Updatable interface, and the field that Updatable does provide - viewerCanUpdate - is not actually available for Milestone. So updatedAt and createdAt were just added as fields to Milestone.


#5

Oh excellent, that works too :raised_hands:, thanks for the quick turnaround on this one!